Robin Linacre

Results 234 comments of Robin Linacre

I think the y axis 'score' refers to the 'precision or recall score'. (just 'score' because it's used for both metrics). But can see that's a potential source of confusion...

Should we remove `linker.confusion_matrix_from_labels_table` i.e. [this]( https://moj-analytical-services.github.io/splink/charts/confusion_matrix_from_labels_table.html) seems superfluous to have both ? Given the functionality is so similar I wouldn't be worried about breaking backwards compatibility

@samnlindsay i edited the above because you referenced 2020, but i think you probably meant 2010

No worries, just didn't want to edit without you knowing in case i did it wrong!

Yep it should be viable, see: https://github.com/moj-analytical-services/splink/issues/1994#issuecomment-1960938890

See https://github.com/moj-analytical-services/splink/pull/2195

Thanks - your proposal makes complete sense in terms of why you'd want this. The term frequency part is very hard to achieve as a built-in Splink feature without introducing...

Thanks for the report. Should be fixed by https://github.com/moj-analytical-services/splink/pull/1965

Closed by https://github.com/moj-analytical-services/splink/pull/1965

One part i'm a bit confused about is: ```python @property def _source_dataset_col(self): input_column = self._source_dataset_input_column return (input_column, InputColumn(input_column, self).name()) ``` ```python @property def _source_dataset_column_name(self): if self._settings_obj_ is None: return None...