Robin Linacre comments

Results 234 comments of


                                            Robin Linacre

[FEAT] Add training rules to settings object

Converting to a discussion because still unsure whether this is desirable

Add method to quickly open chart in the editor from Observable

Agreed, this would be useful. For anyone else seeing this, for the moment you can do this: `embed(vl_api_chart.toSpec())` where ``` embed = require("vega-embed@6") ``` (`toJSON` is deprecated I believe)

string provided must be lowercase

+1 just encountered it with an s3 path that had capitals in it

Split out metadata schema and description from etl_manager to metadata_schema repo

Another pro: The schema is not actually python specific. For instance, we may want an R package that imposes metadata conformance on a dataset. So it makes sense for the...

Split out metadata schema and description from etl_manager to metadata_schema repo

I made [this](https://github.com/moj-analytical-services/metadata_schema) but we can delete if we decide we don't want

`linker.estimate_u_using_random_sampling` fails with default arguments, with no clear indication why

Tricky, especially since it's unlikely the user will have an intuition for the ''correct'/'best' parameter (it wouldn't be very good if they set it to like, 100 or something!) I'd...

`linker.estimate_u_using_random_sampling` fails with default arguments, with no clear indication why

Agreed - i think a warning if it's left as the default should suffice

When call autoindent, give informative error message if '(all)' not detected

This may be fixed now - need to add some tests. It was fixed (I think) by changes in #100

Allow automatic cross tabs with multiple top header rows

Possibly a better approach is to produce a lookup between the columns and their concatenated version from the original data, then use this to retrieve the dual headers

Test duration of debug_mode tests significantly increasing total time of test suite

One simple solution would be to disable for Spark; i can't remember whether we observed cases where debug mode failed for Spark but nothing else