typeorm-fixtures icon indicating copy to clipboard operation
typeorm-fixtures copied to clipboard

fix(builder): fix loads for relation with lazy loading set to true

Open kevin-lot opened this issue 2 years ago β€’ 4 comments

fix loads for relation with lazy loading set to true and rework some tests to work with memory database (and not mocks)

The fix: https://github.com/RobinCK/typeorm-fixtures/pull/198/files#diff-a958cbc039c63bc97979da7c9fe89951b68123f8ffaf17b6cf4dde65532259bbR34 :)

kevin-lot avatar Jul 03 '22 19:07 kevin-lot

@RobinCK What do you think about this PR ? I would like to have your opinion ?

kevin-lot avatar Jul 04 '22 08:07 kevin-lot

I like it, but it no longer looks like a unit test, but more like an integration test, as sqlite is used I approved pr since the integration test adds reliability

RobinCK avatar Jul 04 '22 18:07 RobinCK

"but it no longer looks like a unit test"

I'm going to try to mock of "create" method of repository. For now, I keep this PR in draft during my investigation.

kevin-lot avatar Jul 04 '22 22:07 kevin-lot

Hello @kevin-lot, any progress on this? πŸ˜„

Chrisp1tv avatar Mar 07 '24 14:03 Chrisp1tv