Robert Rosca

Results 31 comments of Robert Rosca

> Since sqlmodel has been broken since, I guess, May (?) with this PR unmerged since May, should I assume sqlmodel is unmaintained? Not a gripe at all, just trying...

> > This has been the cause of at least two issues (#255, #315) but probably more. > > Note that #255 was opened on Feb 28, while SQLAlchemy 1.4.36...

```python3 model = session.get(MyModel, 1) id: int = model.id # ID may be None error ``` The issue here isn't that `id` may be `None`, it's that `model` may be...

Oops, didn't see your comment, I changed it to use the fixture as you suggested. I originally wrote it using the pathlib methods instead of `os.path.join` like this: ```python read_only_resources...

> Thank you for pitching in, @RobertRosca, and sorry that this stalled. As I mention on a code inline comment - I believe the functional equivalent of the proposed change...

Hi @betatim, just poking you in case the PR fell a bit too far down the todo list :stuck_out_tongue: no rush though! Oh and Happy New Year!

Rebased onto main since there were some conflicts

Hi, thanks for the comment! Had some poor timing with this issue since I made it, then went on holiday for a few weeks and completely forgot about it by...

@betatim alright, have some time to start looking at this now, sorry for the (long) delay! > What is your impression of the community around poetry? Have they been around...

Sure, I'll give it a go some time this week. Just wanted to check if it was a good idea before working on the PR :smile: