phpbb-ext-topictags icon indicating copy to clipboard operation
phpbb-ext-topictags copied to clipboard

Fixed Background, Display Tags in Search View

Open PhocaCz opened this issue 8 years ago • 5 comments

3 new commits:

  1. Fixed problem with background image, see the description of this problem: https://www.phpbb.com/community/viewtopic.php?f=456&t=2263616&p=14479291#p14476431 Background problem

  2. Displaying tags in search view (function):

  • Your Posts
  • New Posts
  • Unread Posts
  • Unanswered Topics
  • Active Topics
  1. Displaying tags in search view (template)

PhocaCz avatar Jul 18 '16 10:07 PhocaCz

Hi, thanks for collaborating!! Find some annotations above, could you please incorporate them?

RobertHeim avatar Jul 19 '16 10:07 RobertHeim

Hi,

  1. wrappers - they are not needed but they can help when modifying output per CSS, see example Topic Tags there is need to style different views differently so this is why they have different class names

  2. rh_topictags - if this will fix the problem with displaying, then yes, of course

  3. search_modify_tpl_ary - yes, the function is in fact copied from viewforum_modify_topicrow. There is one other small issue: if ($this->config[prefixes::CONFIG.'_display_tags_in_viewforum'])

Maybe there should be new config value for search view, for now the viewforum config is used, so it is in fact not correct.

Please, take this pull request as inspiration, I am new to phpBB coding, so for example, I am not able to do config parameter for the displaying in search view, etc. If you like the changes and you have idea how to implement the changes better way, please use your way.

Thank you.

PhocaCz avatar Jul 19 '16 22:07 PhocaCz

Thanks so much for this! It fixed the problem!

jlgager24 avatar Feb 26 '17 04:02 jlgager24

Has this extension been abandoned?

theantnest avatar Oct 23 '17 09:10 theantnest

@theantnest, One year without any update, I think so.

Galixte avatar Oct 27 '17 02:10 Galixte