Robert Craigie

Results 208 comments of Robert Craigie

@HKGx I've pushed some minor changes and small fixes. Some thoughts: - I'm happy with the name change of `PRISMA_CLI_URL` to `PRISMA_CLI_MIRROR` and `PRISMA_ENGINES_MIRROR` but we need to document that...

@leejayhsu I misspoke in my original comment. You are correct, the results of the query batcher are currently ignored. The only place pydantic objects are unconditionally created are in `actions.py.jinja`...

We should probably also refactor the test suite to reduce the boilerplate required, could borrow some ideas from https://github.com/prisma/prisma/pull/12560.

Thanks for the report. It is completely safe to remove the `/tmp/prisma-binaries` folder as Prisma Client Python doesn't use it and that directory is only created when running the packaged...

@farzad-salimijazi Unfortunately it's not supported yet. This is a more difficult feature to implement as we currently only run tests against SQLite and PostgreSQL, so before I can even start...

Something I didn't consider when creating this issue is the file size limit on PyPi, this appears to be 60MB. Running a naive `tar -zcvf binaries.tar.gz BINARIES_DIR` creates a 79MB...

Successfully uploaded the packaged binaries to [testpypi](https://test.pypi.org/project/prisma-client/0.0.3/#files)

The only concern I have with this is increasing install times on slower connections, however this could probably be mitigated by packaging a platform agnostic wheel that doesn't include the...

Upon further thought I do not know if the slow download time would matter that much as the binaries would have to be downloaded anyway to use the library.

Could use https://github.com/ziglang/zig-pypi for inspiration.