bigheads icon indicating copy to clipboard operation
bigheads copied to clipboard

Remove superfluous noop values

Open Badlapje opened this issue 1 year ago • 6 comments

Prior to this change several of the maps had multiple noop/none values. One "noop/none" value per map is more than sufficient.

This change ensures all extra noop/none values are removed.

Badlapje avatar Nov 24 '23 15:11 Badlapje

@RobertBroersma Not sure why there are multiple none versions for several of the possible attributes, but this ought to fix it.

Badlapje avatar Nov 24 '23 15:11 Badlapje

@Badlapje The extra noop values are there to prevent a disproportionate amount of facial hair and hats in randomly generated characters.

I know it's not pretty, but it works :-)

RobertBroersma avatar Nov 24 '23 15:11 RobertBroersma

ah, if that's the idea, i can solve the visual without affecting the random generation, just a sec

Badlapje avatar Nov 24 '23 16:11 Badlapje

@RobertBroersma fixed it by adding a new object for the random generation, is this acceptable?

Badlapje avatar Nov 24 '23 16:11 Badlapje

@Badlapje Idk, it's kind of swapping out 1 bad hack for another slightly better hack. I guess this is fine, but I'll have to find some time to boot up this project, it's been a while.

May I ask why you need this fix?

RobertBroersma avatar Nov 24 '23 16:11 RobertBroersma

I'm incorporating the bigheads as user avatars atm & i don't want to show several none values in the dropdown for facialHair and hats. I could just not use the hatMap and facialHairMap, but given that they are there it seems more logical to use them, in case some valid value changes down the road.

You can see it on your own site: the dropdown is confusing for users atm

afbeelding

Badlapje avatar Nov 24 '23 16:11 Badlapje