Robert Parker

@dallan-keylogic thanks for trying this out. See my first attempt at this functionality in #2643. Can you test this out and see if it behaves as you would expect? It...

#2651 has been merged, which covers the basic utilities I initially wanted, so I'm closing this issue.

I just profiled this with the following script, which uses my branch: https://github.com/Robbybp/idaes-pse/tree/parallel_constraints-timing. This relies on the `distill_DAE.py` and `distill.dat` files from the Pyomo [examples](https://github.com/Pyomo/pyomo/tree/main/examples/dae) directory. ```python from pyomo.environ import...

> Frankly, I'm shocked that the (v1, v3) pair was missed by the old method (and that seems to have become undone with minor changes). This is because, with a...

@dallan-keylogic I'll review this later, but I see no reason not to request another review.

I have a diagnostics example I'm working on that relies on `check_parallel_jacobian`. When I run with the current implementation, I get 11 pairs of parallel constraints, but when I run...

This PR still displays way more parallel constraints than I expect on my example, which has been merged into the examples repo. Here is code to reproduce: ```python from idaes_examples.mod.diagnostics.gas_solid_contactors.example...

I'm not sure how I feel about further reducing the tolerance. Then Jacobian rows `(1.0, 1.0)` and `(1.0, 1.0+1e-14)` will not be considered parallel, which doesn't seem like what we...

> Then Jacobian rows `(1.0, 1.0)` and `(1.0, 1.0+1e-14)` will not be considered parallel This is not correct. I see your point that our current measure of "distance-from-parallel" scales with...

@dallan-keylogic I opened a PR into this branch, https://github.com/dallan-keylogic/idaes-pse/pull/4, that attempts to implement the original algorithm in a vectorized manner. Take a look when you have a chance.