Robert Parker

Results 65 comments of Robert Parker

@andrewlee94 What do you mean by model verification? Testing that use cases work from a software/tractability perspective, or that they give us the results we expect (possibly by comparing with...

What you added in IDAES/idaes-dev#1008 is exactly what I was going to do for Caprese.

As far as I'm aware, `categorize_dae_variables` is obsolete and can be deprecated. I forget the exact reason I left it in, but I think it was for a vague performance...

After discussing with @kuanhanl, including on PRs https://github.com/Robbybp/pyomo/pull/5 and https://github.com/kuanhanl/pyomo/pull/1, I've made some changes that I think will make this framework more amenable to MHE. These include: - Updating the...

@blnicho Thank you for looking at this thoroughly. I've addressed your comments, and this is ready for re-review.

I needed the DerivativeVar for the momentum balance equation, and I didn't want the "auxiliary" deltaP variable. I agree that it's not the biggest deal if deltaP (and its equality...

I would prefer to just split up the API between constructing the derivative and constructing deltaP (and its equation). Making deltaP a reference would eliminate the auxiliary equation, but would...

Not sure why all Andrew's commits from #1375 are showing up here...

Looks like this is breaking tests with new numerical warnings. I'll have to look into this.