Robert Parker

Results 65 comments of Robert Parker

Have you looked at what I implemented in https://github.com/andrewlee94/idaes-pse/pull/17 ? It is a working implementation of what I've described here. I'm interested to see your implementation as well.

@andrewlee94 Out of curiosity, why are `-m performance` and `--performance` both required?

@andrewlee94 I believe inheriting from `TestCase` doesn't change what `pytest` will run, but it does change what `unittest` will run. The only reason this is an issue is that I...

Another comment is that the HC_PR test takes about 5 minutes to run on my laptop. Is this too long?

@andrewlee94 A `calc_var_kwds` argument, which should be a dict of arguments to pass to `calculate_variables_from_constraint`, already exists in `solve_strongly_connected_components`! I added it because at some point I needed to send...

@dallan-keylogic Thanks for opening this issue. This patch looks good, although I would also like an `active=True` optional argument that, by default, only descends into active blocks. I think the...

@dallan-keylogic Can you open a PR with this patch and a test indicating the desired (currently failing) behavior.

Another utility that would be useful would be the ability to start/stop a timer with a context manager, e.g. ```python >>> with timer.context("a"): >>> sleep(0.1) >>> print(timer) Identifier ncalls cumtime...

My approach here is to define a "dependency DAG" of scaling factors based on the expressions used to calculate them, then calculate scaling factors in a topological order of that...

Did not mean to close. I'll be thinking about this more as I try to implement my scaling strategies on the CLC unit model classes.