Robin Freyler
Robin Freyler
> > > I am almost finished with my fall semester at university and will be able to work on `apint`. Are you ready to accept PRs quickly? As always:...
> For brevity in internal tests, should I add a bw!() macro which creates and unwraps BitWidths? The different syntax highlighting and bang should make it visible enough to be...
I was also already thinking about this and also to use other things such as `MaybeUninit`, `ManuallyDrop`. I think `apint` could make use a lot more of those new abstractions.
I really liked the write up and I think `apint` could really profit from this. As far as I know our current div-rem algorithms are basically an advanced long-division and...
Well in Rust these methods are called `rotate_left` and `rotate_right` and I think we should just do the same.
Hey, sounds good! Can you please make a PR so I can review it? Also would be very nice if you could show some benchmarks here. How is the algorithm...
Hmm, .. I am currently thinking about the semantic meaning of a rotate function for machine integers. What is it? For shift-left we for example can conclude that it is...
Ah okay for crypto-foo it might be an interesting operation! It is based on: https://llvm.org/doxygen/classllvm_1_1APInt.html
I think we should stick to the Rust convention here and use `rotate_left` and `rotate_right` here. Could you please also do some elaborations (in form of documentation) on how to...
That sounds super awesome! I really appreciate that being merged with proper docs and some benchmarks for a show-off for the next public release. :)