Robin Freyler

Results 406 comments of Robin Freyler

How about this: you develop this functionality in a Wasmi fork and once development is finished and polished you can open a PR and we can discuss the proposed inclusions...

@vanhauser-thc what is your opinion or thinking on the above?

@vanhauser-thc Is this still on your agenda? The [link to the referenda](https://polkadot.polkassembly.io/referenda/942) in the first post seems to be broken. Or can this be closed?

Hi @royaltm , thank you for your feature request. Given that Rust's own `Vec` type has `try_reserve` and `push_within_capacity` on `nightly` channel with similar semantics I think the addition of...

@royaltm thank you for the PR! I think this PR generally goes into the right direction. The `RawMap` API should have been implemented and used by the `StringInterner` long ago,...

> As for the RawTable API, I'm not quite sure what advantage it would have over current implementation. Perhaps just less intermediary function calls? I have read somewhere that the...

> I suppose moving to `RawMap` interface should be only an internal change. I propose we can tackle this issue _after_ the one at hand. > > Regarding `try_reserve` and...

I just ran benchmarks for this branch locally and compared them to the current main branch. Unfortunately I saw quite some big performance regressions with this PR: - `get_or_intern/fill-empty/new/`: ~10%...

All in all this looks good. The benchmark regressions need to be fixed before we can merge though.

I have not (yet) looked into the changes in detail though I looked into the changes done to Wasmi v0.34.0: https://github.com/stellar/wasmi/commit/c5b7c4315db549b01755a387fb142a12fcbe1148 Particularly there are changes to the Wasmi fuel API...