ssl_graph icon indicating copy to clipboard operation
ssl_graph copied to clipboard

Define better X_train and X_test

Open terry07 opened this issue 4 years ago • 1 comments

You may need to elaborate the readme file. During the introduction of the two methods, you use the term X_test for describing the unknown instances that you want to predict, but your documentation fluctuates at this point:

--> y_pred = label_propagation(y_labeled, X_labeled, X_unlabeled, X_train, gaussian_kernel(std), mu) Thus, in the above line you should replace the X_train with X_test variable, as well as into the code.

Thanks for the implementation.

terry07 avatar Feb 08 '21 13:02 terry07

Hi @terry07,

Thanks for diving into this issue!

It seems you have a clear understanding of the code (it has been a while for me). Might you want to submit a pull request? Then future people will benefit from your insights.

Thanks in advance, Rob

RobRomijnders avatar Feb 08 '21 18:02 RobRomijnders