chrome-github-jira
chrome-github-jira copied to clipboard
RobQuistNL
Prevent PR template insertion when the textarea is already populated
Steps to Reproduce
- Go to a "Open a pull request" page
- The extension will fill in the PR template
- Type some information to prepare the PR for review
- Reload the page
- The information will show in the textarea for a brief moment
- The extension will fill in the PR template, erasing previous work & effort 🙁
oof, that sounds nasty! Good suggestion. Will see if I have time to implement this, probably shouldn't be too hard!
@RobQuistNL @blakegearin, this was the exact feature that has been working for me for the last 2 years. Now, the template doesn't even show up while creating a new PR :(
Is there any workaround?
@RobQuistNL, when creating a new PR, GitHub automatically fills in the Title and Description fields using one of the initial commits from the branch. However, since we are now checking for empty values before applying the default template, this causes an issue because GitHub has already populated these fields. I recommend adding an option to control this behavior, which would help resolve the problem.
@rishabh-sagar-20 Ctrl + A to select all of the description, then delete and refresh.
You mean there's a "PR Template" in the .github folder in the repo and thats not being overwritten by this extension?
In my opinion thats by design - I don't want to overwrite any repo specific PR templates.
Or are you talking about something else? If its the first case, maybe we can add a button to "force" the Github-Jira PR template.
You mean there's a "PR Template" in the .github folder in the repo and thats not being overwritten by this extension?
In my opinion thats by design - I don't want to overwrite any repo specific PR templates.
Or are you talking about something else? If its the first case, maybe we can add a button to "force" the Github-Jira PR template.
@RobQuistNL, It's not a repository-specific template; GitHub fills it in during the initial page load. The "force" button should work.
@rishabh-sagar-20
Ctrl+Ato select all of the description, then delete and refresh.
@blakegearin, it was not working in my case somehow. I will give it a try again.
Is this repository you talk about public, so I can check it out? Because if what you're saying is happening it means it shouldn't work at all for any PR. :thinking: