chrome-github-jira icon indicating copy to clipboard operation
chrome-github-jira copied to clipboard

Update manifest.json

Open RobQuistNL opened this issue 2 years ago โ€ข 3 comments

Add optional permissions

RobQuistNL avatar Dec 15 '22 10:12 RobQuistNL

We will still need to run an async request to ask for permission for a certain custom URL, but this is also needed to run Jira on custom domains.

Can do it much like here; https://github.com/helmus/Jira-Hot-Linker/blob/master/jira-plugin/src/background.js#L26

RobQuistNL avatar Dec 15 '22 10:12 RobQuistNL

@CodiumAI-Agent /review

RobQuistNL avatar Jul 27 '23 19:07 RobQuistNL

PR Analysis

  • ๐ŸŽฏ Main theme: Update to the manifest.json file to add optional permissions
  • ๐Ÿ“Œ Type of PR: Enhancement
  • ๐Ÿงช Relevant tests added: No
  • โœจ Focused PR: Yes, because the title and description clearly state that the purpose of the PR is to add optional permissions to the manifest.json file, and the code changes directly reflect this.
  • ๐Ÿ”’ Security concerns: Yes, the added permission ':///*' is a wildcard permission that grants access to all URLs. This could potentially introduce security risks if not handled properly. It is recommended to specify permissions as narrowly as possible to minimize potential security risks.

PR Feedback

  • ๐Ÿ’ก General PR suggestions: The PR is straightforward and focused, which is good. However, it would be beneficial to provide more context in the PR description about why these optional permissions are being added. Additionally, it would be helpful to include tests to verify that these permissions are working as expected.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve: Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit. /ask <QUESTION>: Pose a question about the PR.

CodiumAI-Agent avatar Jul 27 '23 19:07 CodiumAI-Agent