github enterprise?

[Psidium]

Hey, great extension.

Could you do it with github enterprise? Thanks!

[Psidium]

I helped this guy to test his extension, maybe you can implement something like this? https://github.com/Justineo/github-hovercard/commit/3e0e6f5adb58512e2c0e23d9d3b96688ff6865db Justineo/github-hovercard#6

[RobQuistNL]

I currently don't use it so its going to be hard for me to test :( I will probably soon have access to Github Enterprise and might benefit from it as well, will keep you updated.

[Psidium]

I can test it on the instance I have access, probably only needs to remove from manifest.json the GitHub.com dependency and allow the variable GitHub url setting from the extension settings.

2018-02-01 20:32 GMT-02:00 Rob Quist [email protected]:

I currently don't use it so its going to be hard for me to test :( I will probably soon have access to Github Enterprise and might benefit from it as well, will keep you updated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RobQuistNL/chrome-github-jira/issues/21#issuecomment-362424519, or mute the thread https://github.com/notifications/unsubscribe-auth/ACt2Q7xbZm0iabqqGee091gP0NTPwFUmks5tQjuAgaJpZM4R2TnJ .

-- Gabriel Borges Fernandes

[RobQuistNL]

Thanks, sorry for the late reply, I will look in to this by making an MR. If you could test that PR for me that would save a lot of hassle :)

[jrschumacher]

@Psidium is this still something you're looking for?

[Psidium]

@Psidium is this still something you're looking for?

@jrschumacher Still using this setup, so yeah

[jrschumacher]

@Psidium So you just need the ability to specify the github domain? One challenge will be with getting access via the manifest.

I see that Github Hovercard uses the optional permissions.

This is defiantly something which @RobQuistNL would need to decide on since they manage the deployment of the extension. Additionally, you don't want to install an extension that can access ALL urls. That is sketchy. I can help with the option to set the github URL, but you'll need to check it out and install the extension manually.

[RobQuistNL]

This might be fixed in v1.3.0 :) let me know (if its not outdated yet)

[Psidium]

I can set custom jira URLs but I couldn't find a way to set the github enterprise URL

[RobQuistNL]

Crap, sorry. Yeah that is still todo. I'll reopen this and get to it soon™!