react-custom-scrollbars-2 icon indicating copy to clipboard operation
react-custom-scrollbars-2 copied to clipboard

Add support for React 19

Open marcauberer opened this issue 11 months ago • 6 comments

Add support for React 19

marcauberer avatar Dec 15 '24 21:12 marcauberer

@RobPethick can you take a look at this? Seems like many folks are interested. Thanks!

marcauberer avatar Jan 05 '25 09:01 marcauberer

@RobPethick Can we borrow 5 minutes of your time to hit that merge button?

tutturen avatar Jan 24 '25 10:01 tutturen

I guess it's time for a React-custom-scrollbars-3

AKiranB avatar Feb 14 '25 09:02 AKiranB

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 It does not give me a lot of confidence, tbh. And no React 19 support either.

I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me.

Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

barrenechea avatar Feb 14 '25 11:02 barrenechea

Ok, just released react-custom-scrollbars-4 @ v4.5.1, cherry-picking 0ff4d8c and added a GitHub Actions workflow for transparency during build & publishing. v4.5.1 run here.

I'll give it some more love during the weekend 😄

barrenechea avatar Feb 14 '25 12:02 barrenechea

Looking good @barrenechea. Thanks for doing this. Will make the switch over the weekend. Happy to try to contribute if I can in the future 🙏

AKiranB avatar Feb 14 '25 12:02 AKiranB

Please merge this PR. I need this package in the latest version as I am using Node.js version 20.12.2.

dhruvsemicolon avatar Mar 26 '25 07:03 dhruvsemicolon

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 It does not give me a lot of confidence, tbh. And no React 19 support either.

I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me.

Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

this is also not working it says npm error While resolving: [email protected] npm error Found: [email protected] npm error node_modules/react npm error react@"^19.0.0" from the root project npm error npm error Could not resolve dependency: npm error peer react@"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from [email protected]

dhruvsemicolon avatar Mar 26 '25 07:03 dhruvsemicolon

@dhruvsemicolon Before you start giving thumbs down on peoples comments - did you even spend 30 seconds to actually read this thread? React custom scrollbars 3 just points to this repository, as we speak about right above this comment.

AKiranB avatar Mar 26 '25 07:03 AKiranB

@dhruvsemicolon Before you start giving thumbs down on peoples comments - did you even spend 30 seconds to actually read this thread? React custom scrollbars 3 just points to this repository, as we speak about right above this comment.

TY @AKiranB, I honestly have no words for what just happened...

I guess it's time for a React-custom-scrollbars-3

Name already hoisted: https://www.npmjs.com/package/react-custom-scrollbars-3 It does not give me a lot of confidence, tbh. And no React 19 support either. I can give it a go with a quick publish of this commit. This project needs some love as well (migrate to native TypeScript instead of static type definitions, migrate to functional components, self-publish via GitHub Actions come to mind), sounds pretty fun to me. Not sure if react-custom-scrollbars-4 would be okay, though 😆 kinda hate placing numbers within the package name, but at least people could associate it that way...

this is also not working it says npm error While resolving: [email protected] npm error Found: [email protected] npm error node_modules/react npm error react@"^19.0.0" from the root project npm error npm error Could not resolve dependency: npm error peer react@"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from [email protected]

facepalm

barrenechea avatar Mar 26 '25 11:03 barrenechea