Robert Einhorn

Results 31 comments of Robert Einhorn

I submitted a [PR](https://github.com/antlr/antlr4/commit/b91a6aac16d19d01e168a8c30da904262181d546) to fix it.

> Fix that `case [a, *_] if a == 0:` throws error `rule soft_kw__not__wildcard failed predicate: {this.isnotEqualToCurrentTokenText("_")}?` I was able to reproduce the error. This looks like a target independent...

Adding a CPP port is fine, although I am working on such a port as well. The problem is that you are trying to overwrite the newer one with an...

Thanks for the feedback about the two errors. I tested your modified star_pattern rule and it really fixes the "soft_kw__not__wildcard failed predicate" error: ``` star_pattern : '*' NAME; ``` I'll...

Looks like I managed _to_ find and fix the "**_escape quotes character in f-string_**" bug. I'll test it for a few more days. Please change only the things related to...

DEDENT token is placed in the 5th line because it is detected there. Also try Python's tokenizer: `python -m tokenize test.py -e` It also places the DEDENT token in the...

Thanks for bringing this to my attention. I really forgot about that. In other words, the token stream must ensure that the original source code can be restored. And this...

On second thought, no repair is needed after all. The rule is very simple to restore the original source code by the token stream. You just have to take out...

> The second statement says that they cannot be deleted because they are essential to reconstruct the source. The second statement was about the [original Python tokenizer](https://github.com/python/cpython/blob/main/Lib/tokenize.py). > ... Trash...

> The "problem" is on the trtext-side of things. trtext reconstructs the text of the input by concatenating the text of the leaves of the parse tree. So, I see...