ReallySimpleJWT icon indicating copy to clipboard operation
ReallySimpleJWT copied to clipboard

Published 20 hours ago • verified publisher icon RobDWaller

Documentation incorrect

Open lovetoast opened this issue 4 years ago • 5 comments

Hi Mr Waller,

Firstly, awesome library.

Secondly, I believe the readme needs an update.

validateExpiration is performed in validate, and validateExpiration is no longer part of Token?

lovetoast avatar Feb 07 '21 15:02 lovetoast

I'll have a look at this thanks. 👍

RobDWaller avatar Feb 12 '21 13:02 RobDWaller

Also validateNotBefore is performed in validate, but it's not added in Token::create.

markusuntera avatar Feb 15 '21 16:02 markusuntera

Hi, I'm just looking at the documentation and code here and the methods referred to are in the code...

https://github.com/RobDWaller/ReallySimpleJWT/blob/master/src/Token.php#L115 https://github.com/RobDWaller/ReallySimpleJWT/blob/master/src/Token.php#L124

Are you updating from an older version with a slightly different interface?

RobDWaller avatar Mar 09 '21 09:03 RobDWaller

@RobDWaller I believe I used the latest, but when actually attempting to use those functions, they did not work.

lovetoast avatar Mar 09 '21 11:03 lovetoast

Ok, thanks for the feedback, I'm adding some updates to the documentation and will do some more testing to see if something is wrong. 👍

RobDWaller avatar Mar 10 '21 08:03 RobDWaller