Rob Hague
Rob Hague
@Avrohom613 glad to hear it 🙂 > Do you think this could be merged? I'm afraid I am not a maintainer so it is not up to me
1. I agree they look similar. And while I would not say that that PR influenced any of my decisions, I have looked at it in the past, and so...
Sounds good to me. I've rebased anyway to resolve conflicts. Feel free to close it otherwise
A similar feature was added in #1278 (version 30) as `CsvConfiguration.MaxFieldSize`. Is this different?
Have you looked at `CsvConfiguration.PrepareHeaderForMatch`? e.g. ```c# void Main() { string csvString = """ My Property value """; CsvConfiguration config = new(CultureInfo.InvariantCulture) { PrepareHeaderForMatch = args => args.Header.Replace(" ", "")...
Yeah that would be a bit strange. Personally I think your solution is totally valid, but I would probably tweak it slightly: ```c# var map = csv.Context.AutoMap(); // this ensures...
Can you provide a small example which fails? This works for me: ```c# void Main() { var csvConfig = new CsvConfiguration(CultureInfo.InvariantCulture) { PrepareHeaderForMatch = header => Regex.Replace(header.Header, " ", string.Empty).ToLower()...
It looks fine but in this case a picture is not worth much. Can you give a runnable example like mine? What exactly is not working? Are you getting an...
There is a (less than ideal) workaround, but it is not impossible: https://github.com/JoshClose/CsvHelper/blob/7b3ed4d45af8385e732a42eb161b0d129736edb3/src/CsvHelper/CsvHelperException.cs#L141 ```csharp CsvConfiguration config = new(CultureInfo.InvariantCulture) { DetectColumnCountChanges = true }; using StringReader sr = new(""" 1 1,2...
> Just checked, the same applies to non-nullable Guid fields. Indeed, the fix is probably: ```diff diff --git a/src/CsvHelper/TypeConversion/GuidConverter.cs b/src/CsvHelper/TypeConversion/GuidConverter.cs index be70163c..e0ba7915 100644 --- a/src/CsvHelper/TypeConversion/GuidConverter.cs +++ b/src/CsvHelper/TypeConversion/GuidConverter.cs @@ -21,12 +21,9...