Use Service factories in Doctrine MongoDB ODM module

[rieschl]

Due to the latest license incidents in PHP-land, @alcaeus asked me to reach out to you and ask if it's ok to use parts of your service factories in the DoctrineMongoODMModule package.

Most of the factories are the same for ORM and ODM and your AbstractFactory is written quite nicely so I used them to instantiate the services there while upgrading the library to be compatible with mongodb-odm 2.0

Is it ok for you to put a license header to each file stating that it's origin or should I mention it somewhere else (LICENCE, README)?

Thanks!

[Ocramius]

In theory, you'd need to reference the original source and license in the location where you copy the code to.

IANAL, but you'll need to copy the license somewhere too.

[rieschl]

In theory, you'd need to reference the original source and license in the location where you copy the code to.

It's in the files, so that should be satisfied., right?

IANAL, but you'll need to copy the license somewhere too.

So, a notice in the LICENSE file? Symfony has a copyright notice in one of its files, but not a separate notice in the LICENSE file.

So, what should I do? :)

[rieschl]

Hm, @Ocramius if you're bored, you could extract all non-ORM stuff (basically everything except EntityManager- and Migration-stuff) into a separate base package which I can use directly in the DoctrineMongoODMModule. That would be much DRYer and no license-issue 😄

[Ocramius]

Don't think that's architecturally valid.

The code can be copied by just respecting attribution like in LICENSE in this repo.

On Fri, May 29, 2020, 20:28 Thomas Rieschl [email protected] wrote:

Hm, @Ocramius https://github.com/Ocramius if you're bored, you could extract all non-ORM stuff (basically everything except EntityManager- and Migration-stuff) into a separate base package which I can use directly in the DoctrineMongoODMModule. That would be much DRYer and no license-issue 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roave/psr-container-doctrine/issues/24#issuecomment-636121031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFVEADP2DNWPRUN325EBTRT75DTANCNFSM4NN733IQ .

[rieschl]

Update: I went another way with DoctrineMongoODMModule (not using this factories), so it's not an issue, there. But as the DoctrineMongoODMModule needs laminas-mvc I wrote a separate package like this one to be used with Mezzio (or any other PSR container).

In that package I used some files from this library.

I added an attribution in the main LICENSE file and the files which I copied: AbstractOdmFactory, ConfigurationFactory, ConnectionFactory, DocumentManagerFactory

Is that okay for you? Thanks!