Handle "never" type as non float

[fmata]

As MixedType, NeverType implements CompoundType witch always returns yes on isSubTypeOf() calls. It forbids the use of never native PHP type (or as annotation) with this extension.

[fmata]

AFAIK the helper FloatTypeHelper is not tested directly but many tests cover it since it is used everywhere (DisallowFloatInFunctionSignatureRule and DisallowFloatInMethodSignatureRule for my use case). Without my modification in FloatTypeHelper, the tests with my new fixtures in tests/asset fail.

[Ocramius]

@fmata so, to be clear, if we drop the changes to FloatTypeHelper, CI should go red, right?

[Ocramius]

Wait... CI didn't run at all :O

[fmata]

@fmata so, to be clear, if we drop the changes to FloatTypeHelper, CI should go red, right?

Absolutely.

Tests are successful on my side but didn't run here :innocent:

[Ocramius]

I'll have to fix that before a release :D

[Ocramius]

OK, even post-merge, CI didn't run.

Something is fishy 🤔

[Ocramius]

Released meanwhile: https://github.com/Roave/no-floaters/releases/tag/1.6.0

[fmata]

Thanks!