FunctionFQNReplacer icon indicating copy to clipboard operation
FunctionFQNReplacer copied to clipboard

replacement

Open keradus opened this issue 8 years ago • 5 comments

Hi ! Idea behind this package is really great!

This package is not actively maintained, and some time ago, one of open-source contributor bring this feature into https://github.com/FriendsOfPHP/PHP-CS-Fixer/ as native_function_invocation rule.

Maybe you want to deprecate this package and redirect users to PHP CS Fixer to not need to maintain this package ?

keradus avatar Sep 17 '17 22:09 keradus

Sure, just send a patch and we'll let it die 👍

On 18 Sep 2017 00:58, "Dariusz Rumiński" [email protected] wrote:

Hi ! Idea behind this package is really great!

This package is not actively maintained, and some time ago, one of open-source contributor bring this feature into https://github.com/FriendsOfPHP/PHP-CS-Fixer/ as native_function_invocation rule.

Maybe you want to deprecate this package and redirect users to PHP CS Fixer to not need to maintain this package ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Roave/FunctionFQNReplacer/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakH01XGIszADP0MRjtVMFnlF11MuEks5sjaQWgaJpZM4PaT5g .

Ocramius avatar Sep 17 '17 23:09 Ocramius

👍

Off-topic / FYI Was curious about the benchmark, but (quick) installation seems to fail, the suggested:

composer create-project roave/function-fqn-replacer results in

[InvalidArgumentException]                                                 
  Could not find package roave/function-fqn-replacer with stability stable.

and

git clone https://github.com/Roave/FunctionFQNReplacer
cd FunctionFQNReplacer
composer install

results in:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for humbug/humbug dev-master -> satisfiable by humbug/humbug[dev-master].
    - humbug/humbug dev-master requires phpunit/phpunit ^6.0 

holtkamp avatar Nov 02 '17 08:11 holtkamp

yeah, humbug is currently in a "release limbo", where no existing version really works.

Ocramius avatar Nov 02 '17 09:11 Ocramius

try https://github.com/infection/infection perhaps if you search for humbug replacement try PHP CS Fixer if you look for replacement of this package

keradus avatar Nov 02 '17 10:11 keradus

Already fixed similarly via https://github.com/Ocramius/ProxyManager/pull/381 - just waiting for new PHPStan to finalize that and then we can apply it to various repos.

Ocramius avatar Nov 02 '17 10:11 Ocramius