BackwardCompatibilityCheck icon indicating copy to clipboard operation
BackwardCompatibilityCheck copied to clipboard

Use a progress bar indicator to inspect BC breaks

Open Ocramius opened this issue 6 years ago • 4 comments

As discussed with @asgrim in https://github.com/Roave/BackwardCompatibilityCheck/issues/77:

That's acceptable I think... Or maybe simply collect errors and display at the end? Thinking a summary output like phpunit/phpcs like:

.......B......E......
.....B............EEE

Where B is a break and E is an error.. then display them at the end?

This means that array is not a good solution for accumulating BC breaks, and instead yield and yield from must be used aggressively to iterate over the results as they get produced, and inform the user about each step in the process by continuing to produce output.

Ocramius avatar Jun 04 '18 16:06 Ocramius

A progress bar would be really helpful, I am trying to check https://github.com/yiisoft/yii2 and in my last run it took about 5min, just to tell me that I do not have enough memory :)

schmunk42 avatar Jan 28 '19 15:01 schmunk42

@schmunk42 wanna give this a shot, maybe? Also, I think most of the speed problem comes from using the wrong type of SourceLocator ( https://github.com/Roave/BackwardCompatibilityCheck/issues/110 )

Ocramius avatar Jan 30 '19 08:01 Ocramius

To be honest, I don't think I can find time in the near future; so if someone else is planning to do this: "don't hesitate"

schmunk42 avatar Jan 30 '19 14:01 schmunk42

Deferring this: current implementation now uses generators as per #108, which makes the output less painful to wait for.

Ocramius avatar Apr 23 '19 12:04 Ocramius