BackwardCompatibilityCheck icon indicating copy to clipboard operation
BackwardCompatibilityCheck copied to clipboard

Published 20 hours ago • verified publisher icon Roave

Upgrade to PHPUnit v10

Open lcobucci opened this issue 1 year ago • 14 comments

Fix #740

This makes the test suite compatible with the latest PHPUnit version and upgrades everything to it, which removes the SEGFAULTs we were having previously.

(the first commit is from #737, a rebase to sync is more than enough to remove it from the last merged branch)

lcobucci avatar Mar 02 '23 00:03 lcobucci

Replaces #736

lcobucci avatar Mar 02 '23 00:03 lcobucci

Argh, this is possibly blocked by https://github.com/laminas/laminas-ci-matrix-action/pull/189 and https://github.com/laminas/laminas-continuous-integration-action/issues/130

Ocramius avatar Mar 02 '23 10:03 Ocramius

Argh, this is possibly blocked by https://github.com/laminas/laminas-ci-matrix-action/pull/189 and https://github.com/laminas/laminas-continuous-integration-action/issues/130

Fun!

We can "hide" the SEGFAULTs by temporarily relying on exec().

Trade-offs, eh!?

lcobucci avatar Mar 02 '23 11:03 lcobucci

Can't we add it as extension to be installed for this package (at least until that addressed on the upstream)?

Alternatively we can also use a pre-install script to run arbitrary commands as root: https://github.com/laminas/laminas-continuous-integration-action/blob/1.33.x/entrypoint.sh#L162

That might help to only install a coverage driver for specific jobs and allow moving this forward.

lcobucci avatar Mar 02 '23 11:03 lcobucci

I really just need to do the upstream releasing/fixing: however you put the problem, the blocker is me and my constantly clogged schedule :S

Ocramius avatar Mar 02 '23 11:03 Ocramius

I'd be fine with using exec() BTW: the code is well tested anyway, so it's an implementation change only.

Ocramius avatar Mar 02 '23 11:03 Ocramius

I'd be fine with using exec() BTW: the code is well tested anyway, so it's an implementation change only.

I'll send a different PR to tackle this, I've the changes in my local history 👍

lcobucci avatar Mar 02 '23 12:03 lcobucci

I'd be fine with using exec() BTW: the code is well tested anyway, so it's an implementation change only.

I'll send a different PR to tackle this, I've the changes in my local history +1

Scratch that, we can already enable PCOV here and solve the issue.

I've pushed an extra commit and rebased the baseline PR to verify that CI works for both.

@Ocramius @asgrim please approve the workflow run (whenever) on both PRs to make sure things are fine :+1:

lcobucci avatar Mar 02 '23 22:03 lcobucci

Silly me... I've overlooked the generated command for infection on the matrix :facepalm: I used vendor/bin/infection to test, CI is using phpdbg -qrr ./vendor/bin/roave-infection-static-analysis-plugin

Well, that would never work :rofl:

lcobucci avatar Mar 03 '23 07:03 lcobucci

All the things I can think of are horrendous... let's release CI-action v2 :laughing:

lcobucci avatar Mar 03 '23 07:03 lcobucci

Yeah, and phpdbg + pcov together do lead to segfaults :S

Ocramius avatar Mar 03 '23 08:03 Ocramius

@lcobucci doing some paid work, then picking up OCI-CatalogService again

Ocramius avatar Mar 03 '23 09:03 Ocramius