BackwardCompatibilityCheck Support baseline configuration

Support baseline configuration

Open lcobucci opened this issue 2 years ago • 8 comments

This allows users to set a list of regexes to filter known BC-breaks from detected changes.

Feb 15 '23 22:02 lcobucci

@Nyholm although this uses a different name/format, it could be used to simplify https://github.com/Nyholm/roave-bc-check-docker :+1:

Feb 15 '23 23:02 lcobucci

I'll need to ponder on this: my preference would be to have either an XSD or a JSON schema, at least, and use those as documentation too 🤔

Feb 15 '23 23:02 Ocramius

I'll need to ponder on this: my preference would be to have either an XSD or a JSON schema, at least, and use those as documentation too 🤔

I totally understand. I didn't want to introduce new dependencies to the project (I did implicitly add ext-json, though).

Up to you, mate!

Feb 16 '23 06:02 lcobucci

@lcobucci sorry, this is on my plate, didn't get to it though :(

Feb 26 '23 22:02 Ocramius

@lcobucci sorry, this is on my plate, didn't get to it though :(

Wow, the GH ui went crazy there... Just wanted to ask a review from you two (not to spam both).

No worries, we do what we can, whenever we can!

Feb 26 '23 23:02 lcobucci

That segfault seems to be unrelated... let me know if you need help with understanding why it's happening

Feb 27 '23 08:02 lcobucci

All done :+1:

Mar 01 '23 21:03 lcobucci

Hmm, the segfault part still requires a PHPUnit upgrade: checking that first then.

Mar 02 '23 10:03 Ocramius