roaring-rs icon indicating copy to clipboard operation
roaring-rs copied to clipboard

Introduce `insert_range` for RoaringTreemap

Open not-jan opened this issue 3 years ago • 2 comments

Implemented a somewhat naive version of insert_range for RoaringTreemap

~~I wanted to add a separate benchmark to compare the performance of insert_range with collecting from an iterator but was unable to do so because cargo bench would fail with a connection error every time I ran it.~~ Edit: This is fixed now with https://github.com/RoaringBitmap/roaring-rs/pull/225

not-jan avatar Jun 26 '22 18:06 not-jan

Hey @not-jan,

Thank you very much for your work, I appreciate the RoaringTreemap::insert_range method, however, I would prefer that we don't remove the retain_mut dependency right now as I described in #224. Would it be possible to remove this commit from your PR (and description), please?

About the benchmark issue, I think GitHub broke URLs like git://github.com/orga/repo.git. I don't know why it was working before but I just made #225 that you can rebase on. Sorry for the inconvenience. If it works correctly you should be able to add a benchmark 😃 (you must cd benchmarks first and cargo bench).

Kerollmops avatar Jun 28 '22 09:06 Kerollmops

Thank you for the quick response :)

I've performed the requested changes and added my benchmark. I'm not sure whether my benchmark is that effective, since I've copied it from the implementation for the RoaringBitmap. Any opinions about that?

not-jan avatar Jun 28 '22 09:06 not-jan

Merge conflict.

bors[bot] avatar Aug 31 '22 09:08 bors[bot]

Should be all done :)

not-jan avatar Aug 31 '22 11:08 not-jan

Thank you very much! Could you please remove the .idea folder?

I think I erased it from the commit history succesfully but I seem to have accidentally included 9d9b8074de7892ab4e1418e6d4db14eeea3b0819 in my rebase. I can't seem to undo that though as my reflog refuses to return to a state before the rebase started :/

not-jan avatar Aug 31 '22 23:08 not-jan

Build failed:

bors[bot] avatar Sep 01 '22 08:09 bors[bot]