roaring-rs icon indicating copy to clipboard operation
roaring-rs copied to clipboard

Migrate to cargo criterion

Open saik0 opened this issue 3 years ago • 2 comments

https://github.com/bheisler/cargo-criterion

  • cargo-criterion seeks to improve iteration time for Criterion-rs benchmarks. By moving functionality into a separate executable which can be installed once and reused, Criterion-rs can shrink - meaning less code to compile and link into the benchmarks themselves.
  • Because cargo-criterion can oversee the whole benchmark process from beginning to end, it's better placed to deliver features that would be difficult to implement in Criterion-rs. These include: - Machine-readable output - Tracking benchmarked performance over time

This is fantastic. Want. In addition to the above we can get rid of html-reports feature of criterion and bench will have much few dependencies -> faster CI builds.

saik0 avatar Feb 09 '22 13:02 saik0

In addition to the above we can get rid of html-reports feature of criterion and bench will have much few dependencies

What do you mean by get rid of it? Do you mean that we will reduce our set of dependencies but will we keep the HTML reports? I hope so as they were easy to read, crawl, and understand.

Kerollmops avatar Feb 09 '22 14:02 Kerollmops

Right. cargo-criterion can generate all the reports. criterion can just be "just" the benchmark runner.

The idea is to have fewer build-deps for projects that use criterion, since it's lifted out to the cargo-criterion binary.

saik0 avatar Feb 09 '22 14:02 saik0