roadie-backstage-plugins
roadie-backstage-plugins copied to clipboard
feat(instances): each instances can set its own credentials
This Pull Request aims to improve the way we authenticate and get the ArgoCD Token from each instances.
Theses changes will allow instances to define a dedicated username
and/or password
. We can't fully admit that all instances have the same credentials.
https://app.shortcut.com/larder/story/10349
This pull request has been linked to Shortcut Story #10349: feat(instances): each instances can set its own credentials.
@ArthurMialon I am coming from this with no experience of the plugin.. thanks for your patience.
You will need to run the following command and push up the resulting changes.
yarn prettier --write plugins/backend/backstage-plugin-argo-cd-backend
@punkle no problem :) Thanks for your reviews. I just ran prettier
:)
@ArthurMialon You can probably see that its failing the tests. Can you make sure that the following passes:
yarn tsc yarn test
@ArthurMialon do you need help getting this working? Let me know.
@punkle Done :) 🏁
Could you create a changeset file yarn changeset
lets do the changeset in another commit.
Ah I think we need to wait for @karlhaworth and @RoadieHQ/open-source to review this.
@kissmikijr do you know who we need to approve this?
Morning @ArthurMialon,
If you add a changeset (minor bump) to mention these changes in the PR, we can then merge this in and release the plugin
Misclick closed...
Hey @Xantier ! Just added the changeset.
Released with version 2.5.0