roadie-backstage-plugins icon indicating copy to clipboard operation
roadie-backstage-plugins copied to clipboard

feat(instances): each instances can set its own credentials

Open ArthurMialon opened this issue 1 year ago • 12 comments

This Pull Request aims to improve the way we authenticate and get the ArgoCD Token from each instances.

Theses changes will allow instances to define a dedicated username and/or password. We can't fully admit that all instances have the same credentials.

ArthurMialon avatar Aug 24 '22 14:08 ArthurMialon

https://app.shortcut.com/larder/story/10349

roadie-bot avatar Aug 24 '22 14:08 roadie-bot

@ArthurMialon I am coming from this with no experience of the plugin.. thanks for your patience.

punkle avatar Aug 29 '22 08:08 punkle

You will need to run the following command and push up the resulting changes.

yarn prettier --write plugins/backend/backstage-plugin-argo-cd-backend

punkle avatar Aug 29 '22 08:08 punkle

@punkle no problem :) Thanks for your reviews. I just ran prettier :)

ArthurMialon avatar Aug 29 '22 09:08 ArthurMialon

@ArthurMialon You can probably see that its failing the tests. Can you make sure that the following passes:

yarn tsc yarn test

punkle avatar Aug 29 '22 09:08 punkle

@ArthurMialon do you need help getting this working? Let me know.

punkle avatar Aug 30 '22 08:08 punkle

@punkle Done :) 🏁

ArthurMialon avatar Aug 31 '22 13:08 ArthurMialon

Could you create a changeset file yarn changeset

punkle avatar Aug 31 '22 15:08 punkle

lets do the changeset in another commit.

punkle avatar Sep 01 '22 10:09 punkle

Ah I think we need to wait for @karlhaworth and @RoadieHQ/open-source to review this.

punkle avatar Sep 01 '22 10:09 punkle

@kissmikijr do you know who we need to approve this?

punkle avatar Sep 02 '22 08:09 punkle

Morning @ArthurMialon,

If you add a changeset (minor bump) to mention these changes in the PR, we can then merge this in and release the plugin

Xantier avatar Sep 05 '22 07:09 Xantier

Misclick closed...

Xantier avatar Sep 05 '22 07:09 Xantier

Hey @Xantier ! Just added the changeset.

ArthurMialon avatar Sep 05 '22 07:09 ArthurMialon

Released with version 2.5.0

Xantier avatar Sep 05 '22 11:09 Xantier