roadie-backstage-plugins icon indicating copy to clipboard operation
roadie-backstage-plugins copied to clipboard

Support multiple GitHub integrations

Open ConnorDY opened this issue 3 years ago • 4 comments

If you have multiple GitHub integrations setup in app-config.yaml (like shown below), currently this plugin only uses the first one.

integrations:
  github:
    - host: github.com
      token:
        $env: GITHUB_TOKEN
    - host: github.domain.com
      apiBaseUrl: https://github.domain.com/api/v3
      token:
        $env: GHE_TOKEN

Feature Suggestion

Add support for multiple GitHub integrations.

Possible Implementation

I haven't looked at your code yet so I'm not sure.

Context

We are using Backstage with both public GitHub (github.com) and an enterprise GitHub server.

ConnorDY avatar Apr 28 '21 15:04 ConnorDY

@ConnorDY I don't believe Backstage supports this. Have you seen different?

dtuite avatar Apr 28 '21 17:04 dtuite

@ConnorDY I don't believe Backstage supports this. Have you seen different?

@dtuite It does. It even shows this sort of thing in their documentation here: https://backstage.io/docs/integrations/github/locations

ConnorDY avatar Apr 28 '21 18:04 ConnorDY

@ConnorDY Cool. Thanks for suggesting this issue. Makes a lot of sense!

dtuite avatar Apr 28 '21 20:04 dtuite

Hey @ConnorDY thank you for pointing us towards this. It has caught our eye so we checked with the Backstage core team and they have confirmed that unfortunately client-side auth towards multiple different GitHub integrations is not implemented yet so we will wait for them to implement it and follow the pattern after they do. We will however keep this issue open so we can work on that once we have verification that this is resolved. Thank you once again :)

Irma12 avatar May 20 '21 13:05 Irma12

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 31 '23 10:10 github-actions[bot]

Unstale, please.

ltdonner-bah avatar Oct 31 '23 13:10 ltdonner-bah

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 30 '23 13:12 github-actions[bot]