Roaders

Results 117 comments of Roaders

ok, so there is no additional handshake process, just a message to return a new channel. That makes the communication easier... How does this work if agent => proxy communication...

It seems like this isn't working as expected. I created a new PR from my personal repo and the checks still fail: https://github.com/finos/FDC3/pull/1630 but unfortunately it looks like the check...

Yup I have a go at that. I add it here I guess? https://github.com/finos/FDC3/blob/main/toolbox/fdc3-for-web/fdc3-web-impl/test/features/raise-intent.feature

BTW - the new code is fully covered as I didn't add any new branches or functions but we're obviously not testing that apps that were added by event listener...

@robmoffat - I managed to update the tests to pass and to add a new scenario that specifically tests a dynamic app registration. I did have to update an existing...

I actually think that the test that I had to modify to make it pass after my changes has highlighted an issue that I have not previously thought of. If...

@kriswest - the checks now seem to be failing here as well which doesn't seem right.

additional tests passing and I tested it in the workbench. Seems to be all good to me now.

> Issue with BrowerTypes again... I have removed. I don't think that I am doing anything unusual. Right now if I checkout master and `npm run build` new `BrowserTypes` and...