Feature/android support

[choutman]

Android projects are based on Java. However, the Android Gradle plugin has its own way of defining its source sets and the corresponding class paths. In an Android project it is possible to have "build flavors". This enables Android developers to build different kinds of the same Android app using the same code base. For instance a free version and a paid version of the same app.

This pull request enables Android projects to build a class diagram using this plugin. Currently, only Android projects with Kotlin are supported.

[RoRoche]

Hi, Thanks a lot for contributing to this project! It feeds my motivation because is a proof the concept is relevant. 😊🔋 I see that the Travis CI build failed and it reveals failing tests. Did it run correctly locally?

[choutman]

Hi,

I love it when documentation can be generated instead of statically created. So thank you for setting up the project.

I just checked and locally the tests are succeeding. Later this evening I will try to locate the issue. First I thought it was due to different JDK versions, but it's not.

Kind regards,

Coen

On Thu, 10 Sep 2020 at 14:57, Romain Rochegude [email protected] wrote:

Hi, Thanks a lot for contributing to this project! It feeds my motivation because is a proof the concept is relevant :) I see that the Travis CI build failed and it reveals failing tests. Did it run correctly locally?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoRoche/plantuml-gradle-plugin/pull/17#issuecomment-690267385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA326UVOG3XT37JRUQSVPY3SFDELRANCNFSM4REQQV2A .

[codecov-commenter]

Codecov Report

Merging #17 into master will increase coverage by 3.28%. The diff coverage is 48.71%.

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     63.21%   66.50%   +3.28%     
- Complexity       31       43      +12     
============================================
  Files            18       21       +3     
  Lines           174      209      +35     
  Branches          8       13       +5     
============================================
+ Hits            110      139      +29     
  Misses           64       64              
- Partials          0        6       +6     

Impacted Files	Coverage Δ	Complexity Δ
.../roroche/plantuml/urls/CompileClasspathUrls.groovy	33.33% <0.00%> (+33.33%)	1.00 <0.00> (+1.00)
...oroche/plantuml/tasks/BuildClassDiagramTask.groovy	62.06% <16.66%> (-7.17%)	2.00 <0.00> (ø)
...roroche/plantuml/android/AndroidProjectType.groovy	42.85% <42.85%> (ø)	5.00 <5.00> (?)
...roroche/plantuml/urls/MainOutputUrlsFactory.groovy	55.55% <55.55%> (ø)	1.00 <1.00> (?)
...e/plantuml/urls/CompileClasspathUrlsFactory.groovy	62.50% <62.50%> (ø)	2.00 <2.00> (?)
...github/roroche/plantuml/urls/MainOutputUrls.groovy	22.22% <0.00%> (+22.22%)	1.00% <0.00%> (+1.00%)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 918e50c...efcf738. Read the comment docs.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[RoRoche]

Oh nice you made the build passes. Well done! I'll perform the review within a few days. FYI I strongly follow Elegant Objects principles: https://www.elegantobjects.org/ Some rules I can't transgress are: no null, no static, no public method without a declaration in an interface. 😉 Here are some hints about feedbacks I'm gonna make. Happy refactor 😄

[choutman]

Thanks for the review. As you may have noticed I did not have the time yet to make any changes. I'll try to get around it soon.