pct icon indicating copy to clipboard operation
pct copied to clipboard

Class Compile Hierarchy - Doesn't account for parent class include file changes

Open kenherring-rkt opened this issue 3 years ago • 3 comments

Description

When compiling incrementally child classes which reference temp-tables defined in an include which was referenced by the parent class, the child class fails to compile.

Fixes #455

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My branch is started from the latest commit in master
  • [x] My commit history is clean
  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

kenherring-rkt avatar Jan 04 '22 19:01 kenherring-rkt

A few quick notes:

  • I do not believe any documentation changes are required.
  • I was only able to test with 12.2. There are some unit tests which I cannot run because of this, however, this change doesn't appear to affect any of the unit tests that I am able to run successfully.

Please review. I'm happy to make any suggested improvements. 😎

kenherring-rkt avatar Jan 04 '22 19:01 kenherring-rkt

@kenherring-rkt I just see this PR is still open. I won't be able to have a look at it in the coming days, but hopefully I'll be able to do that at the end of February.

gquerret avatar Feb 01 '22 05:02 gquerret

That's fine with me. Thank you.

kenherring-rkt avatar Feb 01 '22 12:02 kenherring-rkt

I didn't expect it would take so long... Thank you for your contribution !

gquerret avatar Sep 16 '22 10:09 gquerret