react-native-code-editor icon indicating copy to clipboard operation
react-native-code-editor copied to clipboard
verified publisher icon RivasCVA

Fix Cursor bug (Android)

Open Kim1254 opened this issue 2 years ago • 6 comments

Kim1254 avatar Jun 19 '23 14:06 Kim1254

@RivasCVA hello, when can i use this pr

yarn add https://github.com/KyeongMin5307/react-native-code-editor.git

OK no problem. I installed the updated package using this command

cetfu avatar Jun 20 '23 10:06 cetfu

I'll look into the changes this weekend, if all looks good, then I'll make it a new release!

(I'm going to assume it works fine on Android, I'll mainly be testing on iOS)

RivasCVA avatar Jun 23 '23 16:06 RivasCVA

Yes. I tested it on android, there is no type problem like before Thank you

cetfu avatar Jun 23 '23 16:06 cetfu

Hi @RivasCVA , will this be merged to main any time soon? thanks!

suXXVI avatar Sep 01 '23 10:09 suXXVI

@KyeongMin5307 @cetfu This PR seems to bring some breaking changes to iOS. It seems that the cursor does not move back when opening any type of brace, and the cursor jumps back to the first line when pressing "Enter" inside a brace pair.

Take a look:

https://github.com/RivasCVA/react-native-code-editor/assets/60367213/dee6b3dc-5346-4c7f-b811-b4b5f6db7b2d

It's hard to fix this bc if I make changes that fix the iOS version, I don't know if it'll break the Android version.

It'd be nice if someone can test both versions at the same time while making the fixes.

RivasCVA avatar Sep 02 '23 16:09 RivasCVA