Cyprian Klimaszewski
Cyprian Klimaszewski
It is independent of the aircraft crashes option
> Either way, I think before this gets fixed, someone needs to decide what the expected behavior is here. Because letting an aircraft crash when the player specifically has turned...
I really like your idea, it preserves the concept of the dropdown and does not add buttons to it. Also only changes the look for modded game because badges are...
It would now make sense to display images before names, as like they are shown in the dropped down part.
I have an Idea how to refactor this PR to match the Project goals, and as it is not simple I would like to ask first for an opinion. 1....
What is the difference between event handler-based approach and the Game::NewEvent()? My idea was to allow game scripts to override the methods, so there would be no need for events.
So how about this approach? It leaves all the logic and interaction with user to scripts and is based on events.
> Currently there is no clear message whether the preview was successful or not. > IMHO even the news message is not desirable. It doesn't mean anything by itself, As...
Should I then continue here or create 2 new PRs: 1. Emphasise drawbacks of engine preview failure to player 2. Allow GS to implement custom engine preview behavior Secondly what...
_Reworked whole PR from scratch. Beneath is corresponding description:_ ## Description ### Additions - Adds 2 new events to GS api: `GSEventEnginePreviewAccepted` and `GSEventEnginePreviewEnded`. The first one is emitted after...