RISHI GARG

Results 28 comments of RISHI GARG

I’ll update the description I have changed the code in the PR but forgotten to change the previous description

@keshav-space I have addressed the review points and I have added tests can you please review the changes again and let me know if any other thing is needed.

Hi @pombredanne @TG1999 @keshav-space @Hritik14 , Can you please review this PR It has passed all workflow tests and was also working fine on my local server. Thank you

@tdruez please see the changes now workflow tests are also successful .

@tdruez I would request you to please review the PR I have made changes In the code after you requested some changes after first review.

> See the various comments. Generally, this implementation seems too complex and not "reusable" enough at it requires to many moving parts. @tdruez what do you mean by "reusable" here....

Hi @tdruez , I have altered code to improve the reusability for that I have made a file `pagination_mixin.py` which contains `PaginatedListViewMixin` class . This logic can convert and ListView...

# Pagination Implementation Documentation ## Core Components of Code 1. **Pagination Mixin** (in `pagination_mixins.py`): 2. **Pagination Template** (in `templates/includes/pagination.html`): ## Implementation Steps 1. **Copy the Mixin** - Create `pagination_mixins.py` in...

@tdruez Here’s the documentation on implementing pagination using this approach. Please review and let me know if any changes are required.

Hi @tdruez and @pombredanne , I have implemented this pagination code in both VCIO and SCIO and it is working nice.It preserved all the filter and add a option for...