Hacktoberfest-2020-Emojipedia icon indicating copy to clipboard operation
Hacktoberfest-2020-Emojipedia copied to clipboard

Published 20 hours ago • verified publisher icon RishabhDevbanshi

Add an error results when there is no result search bar

Open vapx opened this issue 5 years ago • 6 comments

adding error whenever there is no existing emoji can avoid users think that they might have an internet connection problem or the website took to long for them to reload the results/emoji.

vapx avatar Oct 01 '20 08:10 vapx

Great Idea, I'll work on it. Meanwhile you can also give it a try !

RishabhDevbanshi avatar Oct 01 '20 10:10 RishabhDevbanshi

I am also working on it. :)

rohitsingh2410 avatar Oct 01 '20 14:10 rohitsingh2410

@RishabhDevbanshi sir i have made a merge request. could you please check?

rohitsingh2410 avatar Oct 01 '20 14:10 rohitsingh2410

Great Idea, I'll work on it. Meanwhile you can also give it a try !

Sorry for late reply. Yeah I'll give it a try +1:

vapx avatar Oct 01 '20 15:10 vapx

@RishabhDevbanshi can you look at my PR? Error popup added in case there is no matching emoji. #94

rohitsingh2410 avatar Oct 02 '20 14:10 rohitsingh2410

@RishabhDevbanshi Hey, instead of the previously added popup, I just printed a message when no result is found. Please check it out at #135 . Do Let me know if you want to change the message to something else.

ArpitaGanatra avatar Oct 22 '20 16:10 ArpitaGanatra