rise-node icon indicating copy to clipboard operation
rise-node copied to clipboard

Fetching individual multisignature transaction serializes byte buffers incorrectly

Open roosmaa opened this issue 5 years ago • 0 comments

The /transactions/multisignatures/get?id=3645650275543117289 endpoint returns senderPublicKey and signature fields in some object notation, where as it should return hex encoded strings.

{
  "success": true,
  "transaction": {
    "type": 4,
    "id": "3645650275543117289",
    "timestamp": 79394894,
    "senderId": "5748963084999911943R",
    "senderPublicKey": {
      "0": 9,
      "1": 193,
      "2": 96,
      "3": 81,
      "4": 172,
      "5": 70,
      "6": 174,
      "7": 136,
      "8": 13,
      "9": 208,
      "10": 139,
      "11": 207,
      "12": 3,
      "13": 11,
      "14": 208,
      "15": 137,
      "16": 211,
      "17": 205,
      "18": 58,
      "19": 3,
      "20": 234,
      "21": 6,
      "22": 202,
      "23": 134,
      "24": 146,
      "25": 181,
      "26": 29,
      "27": 186,
      "28": 83,
      "29": 173,
      "30": 60,
      "31": 247
    },
    "fee": 500000000,
    "signature": {
      "0": 139,
      "1": 137,
      "2": 67,
      "3": 251,
      "4": 76,
      "5": 234,
      "6": 19,
      "7": 253,
      "8": 208,
      "9": 131,
      "10": 98,
      "11": 242,
      "12": 31,
      "13": 239,
      "14": 192,
      "15": 46,
      "16": 233,
      "17": 33,
      "18": 154,
      "19": 135,
      "20": 180,
      "21": 82,
      "22": 207,
      "23": 49,
      "24": 61,
      "25": 19,
      "26": 105,
      "27": 149,
      "28": 17,
      "29": 66,
      "30": 194,
      "31": 3,
      "32": 212,
      "33": 93,
      "34": 200,
      "35": 149,
      "36": 56,
      "37": 120,
      "38": 230,
      "39": 221,
      "40": 106,
      "41": 239,
      "42": 124,
      "43": 217,
      "44": 69,
      "45": 49,
      "46": 75,
      "47": 182,
      "48": 100,
      "49": 231,
      "50": 126,
      "51": 248,
      "52": 83,
      "53": 127,
      "54": 242,
      "55": 10,
      "56": 213,
      "57": 90,
      "58": 253,
      "59": 96,
      "60": 223,
      "61": 156,
      "62": 252,
      "63": 8
    },
    "signatures": [
      "9efd0f17b46c9181c4008f14ec022c92b191a060c46d5b0da8baf4afe20b9f53c07d9c715314650f534b7d26fa6d7538a2c65c83528037de77580a7c0fc93a0d",
      "7e2b1b8a47ce75c68f6173644feb6698e74ac364a3c3304d819d6463089654c5dac52f210096d83232dc4a1fa28fe18752a05a5d6d5cc24f6d0785aef6560a04",
      "ac3986f0249bbff748c3f9135c7c67094874e848a830342cabec3f5805d014aaf1aeb24e7b1e315922d4637faa0bcc4b0bc5c34c31511becea0b1b0bc98af70e",
      "4a3e91af73d349d4216bd723a8743d8cdcc99b06c04b480398d28c905ba76c6b9e68647213397c8b294e551403074bc202b5975dd76377b909468fd60f85bd08"
    ],
    "amount": 0,
    "asset": {
      "multisignature": {
        "min": 3,
        "lifetime": 60,
        "keysgroup": [
          "+4da375108508d3f82e533297e721e46c49588d4aaad16eeb3563d0c5315c24ea",
          "+19ec2a10fd05f96f182cb3a06c2d82f77d46d2fbcbb5743a1d963125b89c5779",
          "+4a78c10e47009e723e844636def23bf710ed7832fe1bac9a82ab86a18c698b06",
          "+8c08081dc2dc6d1360a3eb5aff0e1ed1791c7698ed88c58f5f5bff5fe0c07b3d"
        ]
      }
    }
  }
}

The /transactions/multisignatures?senderPublicKey=09c16051ac46ae880dd08bcf030bd089d3cd3a03ea06ca8692b51dba53ad3cf7 endpoint returns these fields correctly

{
  "success": true,
  "count": 1,
  "transactions": [
    {
      "type": 4,
      "id": "3645650275543117289",
      "timestamp": 79394894,
      "senderId": "5748963084999911943R",
      "senderPublicKey": "09c16051ac46ae880dd08bcf030bd089d3cd3a03ea06ca8692b51dba53ad3cf7",
      "fee": 500000000,
      "signature": "8b8943fb4cea13fdd08362f21fefc02ee9219a87b452cf313d1369951142c203d45dc8953878e6dd6aef7cd945314bb664e77ef8537ff20ad55afd60df9cfc08",
      "signatures": [
        "9efd0f17b46c9181c4008f14ec022c92b191a060c46d5b0da8baf4afe20b9f53c07d9c715314650f534b7d26fa6d7538a2c65c83528037de77580a7c0fc93a0d",
        "7e2b1b8a47ce75c68f6173644feb6698e74ac364a3c3304d819d6463089654c5dac52f210096d83232dc4a1fa28fe18752a05a5d6d5cc24f6d0785aef6560a04",
        "ac3986f0249bbff748c3f9135c7c67094874e848a830342cabec3f5805d014aaf1aeb24e7b1e315922d4637faa0bcc4b0bc5c34c31511becea0b1b0bc98af70e",
        "4a3e91af73d349d4216bd723a8743d8cdcc99b06c04b480398d28c905ba76c6b9e68647213397c8b294e551403074bc202b5975dd76377b909468fd60f85bd08"
      ],
      "amount": 0,
      "asset": {
        "multisignature": {
          "min": 3,
          "lifetime": 60,
          "keysgroup": [
            "+4da375108508d3f82e533297e721e46c49588d4aaad16eeb3563d0c5315c24ea",
            "+19ec2a10fd05f96f182cb3a06c2d82f77d46d2fbcbb5743a1d963125b89c5779",
            "+4a78c10e47009e723e844636def23bf710ed7832fe1bac9a82ab86a18c698b06",
            "+8c08081dc2dc6d1360a3eb5aff0e1ed1791c7698ed88c58f5f5bff5fe0c07b3d"
          ]
        }
      }
    }
  ]
}

roosmaa avatar Nov 29 '18 15:11 roosmaa