rise-node icon indicating copy to clipboard operation
rise-node copied to clipboard

Deprecating current Address System

Open vekexasia opened this issue 6 years ago • 2 comments

The current address system is collision prone.

User Address is basically a numeric id which is being derived using a slice of the publicKey.

A nice writeup of the known problem can be found here: https://research.kudelskisecurity.com/2018/01/16/blockchains-how-to-steal-millions-in-264-operations/

Addresses can be calculated using ripedm160+b58 just like in bitcoin.

It's important to note that also blocks and transactions have numeric ids afftected by the collision issues described above.

We might take the chance to change the address system to actually think about rewriting transaction ids and block ids.

Note: Old existing entities (txs,blocks) should keep their old ids while accounts could be referenced both with old and new address system.

vekexasia avatar Mar 11 '18 14:03 vekexasia

@vekexasia you talking about this implementation for address calculation? Or you want to implement something more simpler.

alepop avatar Nov 23 '18 09:11 alepop

This is still under investigation. sha256+ripemd160+base58check should be enough Imho.

vekexasia avatar Nov 23 '18 10:11 vekexasia