ripme
ripme copied to clipboard
ImagevenueRipper not working; site has changed significantly - might be worth fixing
The links in the unit tests don't work; see also https://github.com/RipMeApp/ripme/issues/1202
The wayback machine shows this site has changed, but the homepage looks like the site is basically still for the same purpose. So maybe it's worth fixing.
Can you explain me the issue? I didn't understand the context
Hey @metaprime, I would like to work on this issue. Could you please assign me this to me.
Can you explain me the issue? I didn't understand the context
@lakshaybxt I've been doing some debugging and I think I’ve figured out what’s going on.
Since I just came across this project, I don’t have any prior reference to confirm whether Imagevenue used to return a supported content type. But based on what I’m seeing now, the response we get has a content type that the program isn’t expecting.
Specifically, the response returns image/*, which isn’t handled by the HttpConnection class. That seems to be why the unit test for this ripper is currently failing.
@jeenagoyalgoyal any issues tagged "good first issue" are up for anyone to work on at any time
In general, I think the ripper for this site needs to be reimplemented from scratch
Hi, I just finished to fix this issue but I can't push my branch to create the PR, could you assign this issue to me ?