ripme icon indicating copy to clipboard operation
ripme copied to clipboard

finish.command not working

Open emk2203 opened this issue 10 months ago • 3 comments

  • Ripme version: 2.1.16-4-02372e85
  • Java version: openjdk 23 2024-09-17
  • Operating system: Arch Linux updated 2025-01-07
  • Exact URL you were trying to rip when the problem occurred: n/a
  • Please include any additional information about how to reproduce the problem:

command from finish.command runs without issues from command line after executing ripme. enable.finish.command is set to true in ~/.config/ripme/rip.properties. finish.command = cd /home/emk2203/rips; find * -type d -exec 7z a -t7z -sdel {}.cbz {}/* ; && rmdir * 2> /dev/null; cd - is set in rip.properties.

Expected Behavior

After ripping all given URLs, command should run and compress everything ripped to a CBZ archive, then delete the empty directories

Actual Behavior

Error message:

10:53:13.297 [AWT-EventQueue-0] ERROR com.rarchives.ripme.ui.MainWindow - Was unable to run command "cd /home/emk2203/rips; find * -type d -exec 7z a -t7z -sdel {}.cbz {}/* ; && rmdir * 2> /dev/null; cd - 10:53:13.298 [AWT-EventQueue-0] ERROR com.rarchives.ripme.ui.MainWindow - [Ljava.lang.StackTraceElement;@7e7fdc52

Absence of closing quotes in first error log message; finish.command doesn't work even if command is put in quotes in the config file.

emk2203 avatar Jan 07 '25 10:01 emk2203

Does it work if you write the command as sh -c "<command>"?

metaprime avatar Jan 07 '25 21:01 metaprime

No. When I try this, I get the error messages

08:05:19.991 [AWT-EventQueue-0] INFO  com.rarchives.ripme.ui.MainWindow - RUnning command [Ljava.lang.String;@750a6002
08:05:20.002 [AWT-EventQueue-0] INFO  com.rarchives.ripme.ui.MainWindow - Command output:

08:05:20.002 [AWT-EventQueue-0] ERROR com.rarchives.ripme.ui.MainWindow - Command error:

/home/emk2203/rips;: -c: Zeile 1: Dateiende beim Suchen nach »"« erreicht.

End of file reached at the search for "

emk2203 avatar Jan 08 '25 07:01 emk2203

What language are you using btw? I want to look up the place in the code that that error massage comes from. Or is that error message coming from your command itself?

metaprime avatar Jan 27 '25 23:01 metaprime