ripme icon indicating copy to clipboard operation
ripme copied to clipboard

Add trusted certificate to allow downloads from motherless (fixes issue #2009)

Open occipita opened this issue 3 years ago • 1 comments

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • [x] a bug fix (Fix #2009)
  • [ ] a new Ripper
  • [ ] a refactoring
  • [ ] a style change/fix
  • [ ] a new feature

Description

Added a certificate store that is based on the one from OpenJDK 18 with the "GoGetSSL RSA DV CA" certificate added.

Added code in Utils class to load trust stores (based on code found at https://stackoverflow.com/a/10077862/20145163)

Modified App.main to load the certificate store

Testing

Required verification:

  • [x] I've verified that there are no regressions in mvn test (there are no new failures or errors).

     (although I note that there are a number of test failures, these seem to exist in the master branch already)
    
  • [x] I've verified that this change works as intended.

    • [x] Downloads all relevant content.
    • [x] Downloads content from multiple pages (as necessary or appropriate).
    • [x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • [x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • [ ] I've added a unit test to cover my change.

occipita avatar Jan 04 '23 16:01 occipita

@occipita woud you mind to create this on https://github.com/ripmeapp2/ripme ?

soloturn avatar Jun 10 '23 22:06 soloturn