ripme
ripme copied to clipboard
Listal ripper errors out when there is an underscore in the url.
- Ripme version:1.7.95
- Java version: "1.8.0_241"
- Operating system: Microsoft Windows [Version 10.0.19043.1415]
- Exact URL you were trying to rip when the problem occurred: https://www.listal.com/emma-stone_iii/pictures
- Please include any additional information about how to reproduce the problem:
Listal ripper fails if there is an underscore in the URL, like in this case there is an underscore in emma-stone_iii
I changed line 28 in ListalRipper.java from:
private Pattern p2 =Pattern.compile("https:\\/\\/www.listal.com\\/((?:(?:[a-zA-Z0-9-%]+)\\/?)+)");
To:
private Pattern p2 =Pattern.compile("https:\\/\\/www.listal.com\\/((?:(?:[a-zA-Z0-9-_%]+)\\/?)+)");
(Included underscore _ in the pattern right before the percent sign) And it seems to solve the issue. But I don't know how to run all the tests and create a pull request.
Expected Behavior
URLs with underscores should work...
Actual Behavior
URL's with underscores result in Expected listal.com URL format: listal.com/list/my-list-name - got https://www.listal.com/emma-stone_iii/pictures error.
fixed in https://github.com/ripmeapp2/ripme/releases
@soloturn could you make a pr against this repro as well?