ripme icon indicating copy to clipboard operation
ripme copied to clipboard

Mangadex - Allow www prefix and page suffix

Open 0x1f595 opened this issue 5 years ago • 1 comments

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • [x] a bug fix

Description

This updates the Mangadex ripper to make it a bit more relaxed on what URLs it considers valid and can rip. It now allows a "www" prefix on the URL, and correctly rips whole chapters when a page URL within a chapter is given.

Testing

Required verification:

  • [x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • [x] I've verified that this change works as intended.
    • [x] Downloads all relevant content.
    • [x] Downloads content from multiple pages (as necessary or appropriate).
    • [x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • [x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • [x] I've added a unit test to cover my change.

0x1f595 avatar Apr 25 '20 00:04 0x1f595

Tried merging this PR together with main but it looks like the implementation calls an API that maybe doesn't work anymore, so a bigger fix for this ripper is needed.

See #2091

metaprime avatar Feb 02 '25 08:02 metaprime