developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[PLACEHOLDER] Tournament-V5 Bugs/Issues

Open tisbells opened this issue 1 year ago • 52 comments

Placeholder for any issues with Tournament-V5
For Tournament-V5 once live - Please reply to this issue with any technical problems or bugs with the new API.

Not getting callbacks?
Please message us with your callback url and relevant tournament code in app messaging

tisbells avatar Oct 11 '23 23:10 tisbells

We're getting HTTP 500 errors from POST https://americas.api.riotgames.com/lol/tournament/v5/providers now. Our requests were successful in testing yesterday though.

Pikeman avatar Oct 12 '23 00:10 Pikeman

@Pikeman Should be fixed, could you please verify?

tisbells avatar Oct 12 '23 00:10 tisbells

@Pikeman Should be fixed, could you please verify?

It works! Thanks for the quick fix.

Pikeman avatar Oct 12 '23 00:10 Pikeman

We're getting null PUUID on LobbyEventV5DTO:

[
  {
    "timestamp": "2023-10-12 01:14:35.0",
    "eventType": "PracticeGameCreatedEvent",
    "puuid": null
  },
  {
    "timestamp": "2023-10-12 01:14:56.0",
    "eventType": "PlayerJoinedGameEvent",
    "puuid": null
  },
  {
    "timestamp": "2023-10-12 01:15:04.0",
    "eventType": "PlayerJoinedGameEvent",
    "puuid": null
  },
  ...

Pikeman avatar Oct 12 '23 01:10 Pikeman

Hey there!

We are not receiving callbacks after the finished match. The same issue was with V4 API before, and we use an HTTP endpoint with a correct gTLD.

Could you please tell what can be an issue?

MakeevD avatar Oct 12 '23 10:10 MakeevD

Thanks for your patience, we're looking into the above issues and will get back to you soon.

tisbells avatar Oct 12 '23 13:10 tisbells

@Pikeman This should be resolved, please let us know if not. @MakeevD If you could send me your app ID thru Discord or message us in the app notes we'd appreciate it so we can look at the games you're not getting callbacks for. We're looking at callback issues in general, but seeing specific examples is very helpful.

tisbells avatar Oct 12 '23 20:10 tisbells

Hey there!

We are not receiving callbacks after the finished match. The same issue was with V4 API before, and we use an HTTP endpoint with a correct gTLD.

Could you please tell what can be an issue?

+1 on this. @tisbells I can also share the same info if it helps!

EDIT: Sent a friend request on Discord tisbells!

ElijahKSmith avatar Oct 12 '23 20:10 ElijahKSmith

For those experiencing callback issues - "Region" was unexpectedly swapped to "shardId" which may be causing errors for multi-region tournaments. This should be changed back to "Region" on our end early next week. Additionally, you will not receive a callback if the match did not finish to completion or to surrender.

tisbells avatar Oct 13 '23 22:10 tisbells

For anyone else having problems, if there are any bots in the game, you won't get a callback.

seju-play-vs avatar Oct 13 '23 23:10 seju-play-vs

shardId was swapped back to region. Additionally, an issue was found that may have caused some errors for EUW tournaments and this has been fixed.

tisbells avatar Oct 17 '23 20:10 tisbells

@tisbells I had a few callback issues today, have sent you a request on discord, understand that the comment 6mins ago might be the reason, so will also test again tomorrow

OllieJennings avatar Oct 17 '23 20:10 OllieJennings

When the callback is fixed would I need to redo my URL? its been down for months.

DaBenjamins avatar Oct 19 '23 19:10 DaBenjamins

When the callback is fixed would I need to redo my URL? its been down for months.

You've gotta create a new Provider for V5 if you haven't already

ElijahKSmith avatar Oct 19 '23 19:10 ElijahKSmith

When the callback is fixed would I need to redo my URL? its been down for months.

You've gotta create a new Provider for V5 if you haven't already

Was that documented somewhere as a requirement, my old Provider and Tournament IDs kept working on V5

Update: If I try and get a new Provider ID, it just gives me the old one since its the same URL, so I dont see how to get a new ID

DaBenjamins avatar Oct 19 '23 19:10 DaBenjamins

When the callback is fixed would I need to redo my URL? its been down for months.

You've gotta create a new Provider for V5 if you haven't already

@tisbells Is this true? I did not create a new provider, and our v5 code is working.

seju-play-vs avatar Oct 19 '23 19:10 seju-play-vs

When the callback is fixed would I need to redo my URL? its been down for months.

You've gotta create a new Provider for V5 if you haven't already

Was that documented somewhere as a requirement, my old Provider and Tournament IDs kept working on V5

Update: If I try and get a new Provider ID, it just gives me the old one since its the same URL, so I dont see how to get a new ID

Sorry I should've included more information in my original reply to explain why I said that. I meant to say that if it still wasn't working you should try to generate a new one. For my own providers I found that one provider when re-registered with the same information returned the same ID and worked the same, but on two other ones I got new IDs which were needed to make it work. Not sure why that's the case but I figured it might be worth checking.

ElijahKSmith avatar Oct 19 '23 20:10 ElijahKSmith

You should be able to use your original provider with V5.

tisbells avatar Oct 24 '23 18:10 tisbells

You should be able to use your original provider with V5.

any new on when Callback will be working again?

DaBenjamins avatar Oct 24 '23 19:10 DaBenjamins

any new on when Callback will be working again?

@DaBenjamins If you are still experiencing callback issues after finishing a match to completion/surrender, please send us an app message in the developer portal with your callback URL and a recent tournament code.

tisbells avatar Oct 24 '23 19:10 tisbells

Reposting this here from https://github.com/RiotGames/developer-relations/issues/833 - We now have a new endpoint for getting the PUUIDs for Tournaments! https://developer.riotgames.com/apis#tournament-v5/GET_getGames

This will provide the same payload of tournament callbacks + participant PUUIDs. You can also use this endpoint to check if the game was recorded and help debug callbacks. If the endpoint returns the game, it means a callback was attempted. Please let us know if any of you run into problems with this.

tisbells avatar Nov 10 '23 17:11 tisbells

@tisbells i noticed one thing, not sure if intentional or a bug, but when you request the tournament game by code, the metaData seems to be empty.

The server callback had correct metaData, and also requesting the tournamentDTO returns the correct metaData.

OllieJennings avatar Nov 17 '23 15:11 OllieJennings

I dont know if it is how it's work, but im getting trouble to make a tournament (i dont need a web page to see my results (can i use localhost), im testing only to create little tournaments by myself) And you can see i got americas.api when i fill with EUW Captura de pantalla 2023-11-20 034010

R0kiee avatar Nov 20 '23 02:11 R0kiee

@R0kiee the tournament API is only deployed to americas. Any tournament created on americas is valid for the region set in the provider; This has always been how the tournament API works.

Token07 avatar Nov 20 '23 03:11 Token07

@R0kiee the tournament API is only deployed to americas. Any tournament created on americas is valid for the region set in the provider; This has always been how the tournament API works.

@Token07 And something about the other question??

R0kiee avatar Nov 20 '23 03:11 R0kiee

@R0kiee I don't believe the URL needs to be valid. It looks like your attempt to create a provider was successful so now you create a tournament using the providerId returned.

Token07 avatar Nov 20 '23 03:11 Token07

@tisbells i noticed one thing, not sure if intentional or a bug, but when you request the tournament game by code, the metaData seems to be empty.

The server callback had correct metaData, and also requesting the tournamentDTO returns the correct metaData.

@OllieJennings Can you please provide a tournament code where you're seeing this?

tisbells avatar Nov 20 '23 16:11 tisbells

@tisbells i noticed one thing, not sure if intentional or a bug, but when you request the tournament game by code, the metaData seems to be empty. The server callback had correct metaData, and also requesting the tournamentDTO returns the correct metaData.

@OllieJennings Can you please provide a tournament code where you're seeing this?

I dont have server callback (i use test on this field), i only want to test getting a tournament code, i dont know if it makes some issues

R0kiee avatar Nov 20 '23 16:11 R0kiee

@tisbells i noticed one thing, not sure if intentional or a bug, but when you request the tournament game by code, the metaData seems to be empty. The server callback had correct metaData, and also requesting the tournamentDTO returns the correct metaData.

@OllieJennings Can you please provide a tournament code where you're seeing this?

Yep, will send you via discord

OllieJennings avatar Nov 20 '23 19:11 OllieJennings

I can't seem to be able to whitelist puuid's when creating codes in tournament-v5, I'm passing an array to allowedParticipants, however other players (non-whitelisted) can still join the lobby. Is this a bug or am I missing something?

Here's a sample payload I tried:

{
    "enoughPlayers": true,
    "mapType": "SUMMONERS_RIFT",
    "pickType": "TOURNAMENT_DRAFT",
    "spectatorType": "LOBBYONLY",
    "teamSize": 1,
    "allowedParticipants": [...some-puuids]
}

mariandaniel24 avatar Nov 25 '23 01:11 mariandaniel24