developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG] List of missing docs or other problems on lol-challenges-v1

Open geozukunft opened this issue 3 years ago • 3 comments

Bug Description
Below is a writeup of all missing docs or other issues on the lol-challenges-v1 endpoint all collected on a single place grouped by the endpoints.

/lol/challenges/v1/challenges/config

  • Not strictly missing but maybe it would make more sense to move the description of State and Tracking into the description field of the respective fields in the ChallengeConfigInfoDto instead of having them in their own groups which now look like data is missing on the first glance

The above "issue" also applies to /lol/challenges/v1/challenges/{challengeId}/config

/lol/challenges/v1/challenges/{challengeId}/leaderboards/by-level/{level}

  • The path parameter level shows the option to select more options than just MASTER, GRANDMASTER, CHALLENGER are those other options intentional or just shown on the dev portal accidentially? Especially the options HIGHEST, HIGHEST_NOT_LEADERBOARD_ONLY and LOWEST all return a java.lang.IllegalArgumentException: No enum constant com.riotgames.unifiedprogression.entity.Level.[insert selected option here] error.

  • There is no information about the highest possible limit one can choose as the query parameter limit

/lol/challenges/v1/player-data/{puuid}

  • Missing docs for ChallengeInfo
  • Missing docs for PlayerClientPreferences
  • Missing docs for ChallengePoints

geozukunft avatar May 12 '22 10:05 geozukunft

/lol/challenges/v1/challenges/percentiles returns incorrect data format (missing Season data) expected- Map[Long, Map[Integer, Map[Level, Double]]] result - Map[Long, Map[Level, Double]]

AoshiW avatar May 12 '22 11:05 AoshiW

Is it just me, or shouldn't the value field be monotonically decreasing?

[
    {
        "position": 741,
        "puuid": "dal0ZfZVDuaxLiR4VaDx554rEOofdi_ayxN7c5tpq0ef22clNMz7hN-m-ZnN_hQv9srCGXPxG3oWJQ",
        "value": 15
    },
    {
        "position": 742,
        "puuid": "7d0aigTZmFsl6MtcBHboDkJX-31xM-rwQfNtH60yFTyMV6gnkafb1KxCV2Tf-R8VG_YENs6mpJ0vJg",
        "value": 16
    },
    {
        "position": 743,
        "puuid": "lW73pR6E8nRNUb-t1IamJSa6TiLJ2-hwDgb_LxgR9YjgYSMnaSqJrIlwcaDROpZIwQuGGyKgluEtRA",
        "value": 15
    },
    {
        "position": 744,
        "puuid": "rzYtRl8KVCCy2IZ0GEK9DQT20MC2ZTquHbSA5tfkrYMiAfBQ6BL-3rbgkEFqcXHMexoBMwJDKbB8vQ",
        "value": 16
    },
    {
        "position": 745,
        "puuid": "dtT2T0KVHHNvzeF7anauqcMHUs7zOrRHMGWTEU9dMNeqEXv37Ne8lqMJi5pAt2gFBdmlxbwv-3N3Vg",
        "value": 15
    },
    ...

15, 16, 15, 16, 15, 16, 14, 14, 14 ... ?

https://la1.api.riotgames.com/lol/challenges/v1/challenges/101101/leaderboards/by-level/MASTER

MingweiSamuel avatar May 25 '22 23:05 MingweiSamuel

/lol/challenges/v1/player-data/{puuid}

lol-challenges-v1.ChallengePoints

Name Data Type Description
level string Tier string
current long?  
max long?  
percentile double (optional)

lol-challenges-v1.ChallengeInfo

Name Data Type Description
challengeId long
percentile double
level string Tier string
value double?
achievedTime long Timestamp
position long (optional)
playersInLevel long (optional)

lol-challenges-v1.PlayerClientPreferences

Name Data Type Description
bannerAccent string
percentile double
challengeIds List[long] List of max length 3?
crestBorder string (numeric?) NEW 2023-04-01
prestigeCrestBorderLevel integer NEW 2023-04-01

MingweiSamuel avatar May 26 '22 00:05 MingweiSamuel

I'd like to add to this list that there are no docs on the challenges fields in the participant part of match-v5 game data

geozukunft avatar Oct 24 '22 08:10 geozukunft

lol-challenges-v1.PlayerClientPreferences has two new fields, crestBorder and prestigeCrestBorderLevel

MingweiSamuel avatar Apr 02 '23 04:04 MingweiSamuel

If these fields are what I think they are this would actually be fields that we had asked them to add

geozukunft avatar Apr 02 '23 11:04 geozukunft

Thanks for the detailed info - Can't provide an ETA currently, but we will look into this

tisbells avatar Aug 02 '23 19:08 tisbells