developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG] Viego has 10'000 mana (mp) on Data Dragon

Open Vianpyro opened this issue 4 years ago • 2 comments

Bug Description
Viego has 10'000 mana points (mp) on Data Dragon.

Expected Result
Since Viego is a champion that does not use any mana I would expect 0 mp.

Actual Result
image

Developer Impact
As I am trying to display exact stats for every champion and compare them together it seems weird to see that Veigo, who has no mana, is the champion with the most mana in the game.

  • Frequency: Every API call.
  • Severity: Minor, this is just just an incorrect value.
  • Cost: None.
  • Efficiency: Requires me to create an algorithm (complexity O(n^2)) to catch incoherencies in the statistics.

Player Impact
This should not impact league players so it's not a big issue at all.

  • Frequency: Every time the user visits the site, they experiennce this issue.
  • Quantity: There are "<coders using DDragon API>" players that experience this issue.
  • Region: This affects players in every region.

Repro Steps

  1. Send a GET request to https://ddragon.leagueoflegends.com/cdn/<version>/data/<region>/champion.json.
  2. Search for "Viego" and look at his "mp" in his stats.

Issue Comments
This issue is not a major issue and does not need to be fixed urgently, a fix would be appreciated though. Thank you for you hard work :)

Vianpyro avatar Jul 30 '21 01:07 Vianpyro

Use the partype field instead to select what resource a champ uses.

Also work on your algorithms. If processing a linear file from start to end takes you O(n^2), thats an issue.

DoctressWasTaken avatar Jul 30 '21 08:07 DoctressWasTaken

Thank you and I fixed that algorithm x)

Vianpyro avatar Aug 08 '21 13:08 Vianpyro