developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG] No recommended items in the Data Dragon API since patch 11.8

Open Vianpyro opened this issue 4 years ago • 2 comments

Bug Description
No recommended items in the Data Dragon API since patch 11.8.1 (At the moment I write this issue the patch 11.15.1 just got released).

Expected Result
The Data Dragon used to have recommended items for each champion (it was not the best but still better than nothing).

Actual Result
I use the Data Dragon API for a website I'm building for a lot a friends and a Discord server, but there is no recommended item since patch 11.8.1; image image

Developer Impact
As a developer this makes me unable to provide up to date information to my "customers" and I don't have much time to update by hand with my jobs.

  • Frequency: Every API call.
  • Severity: When it happens, no champion has recommended items for the current or previous patch, and some just have no recommended item at all.
  • Cost: Unhappy customers.
  • User emails: I get frequent Discord messages from users asking me about this issue.

Player Impact
The players used to adapt their runes depending on the champion's build before the game started (when they don't really know the champion)

  • Frequency: Every time the user visits the site, they experience this issue.
  • Severity: When this bug happens, users are unable to use my site to anticipate the items they will build. I have around 100 visits to my site each day.
  • Quantity: There are ~50 players that experience this issue..
  • Region: This affects players in every server.

Preconditions
A request to the Data Dragon API must be done.

Repro Steps

  1. Load any champion's (for example Aatrox) JSON from the Data Dragon API.
  2. Compare it to the last patch that returned recommended items(11.8.1).
  3. Get the json['data']['Aatrox']['recommended'] value and see the difference.

Issue Comments
This issue is not a major issue and does not need to be fixed urgently, a fix would be appreciated though. The items you can see in the image above are researched through previous versions of the game (making more and more requests to the API as patches get released without recommended items).

Vianpyro avatar Jul 23 '21 01:07 Vianpyro

The recommended items in ddragon have not been proper since the item rework. The items in the shop were statically defined before the item rework.

Now recommended items are based on the current game and the weaknesses of the enemy team.

This is more than a bug that can be a simple fix, it would have to be a rework to how ddragon provides recommended items to include all of this information.

bangingheads avatar Jul 23 '21 01:07 bangingheads

Do you think it will ever get done or should I totally forget about this list forever?

Vianpyro avatar Jul 28 '21 13:07 Vianpyro