shinydashboardPlus icon indicating copy to clipboard operation
shinydashboardPlus copied to clipboard

Warning due to hardcoded icon in messageItem

Open CorneeldH opened this issue 1 year ago • 0 comments

Hi,

We get the following warnings with out shiny app:

This Font Awesome icon ('clock-o') does not exist:
* if providing a custom `html_dependency` these `name` checks can 
  be deactivated with `verify_fa = FALSE`

After some searching we found the issue, it is hardcoded in the messageItem function shinydashboardplus that we use:

messageItem <- function (from, message, icon = shiny::icon("user"), time = NULL, 
                         href = NULL, inputId = NULL) {
  tagAssert(icon, type = "i")
  if (is.null(href)) href <- "#"
  shiny::tags$li(
    shiny::a(
      id = inputId, 
      class = if (!is.null(inputId)) "action-button",
      href = href, 
      icon, 
      shiny::h4(from, if (!is.null(time)) 
        shiny::tags$small(shiny::icon("clock"), time)), shiny::p(message)
    )
  )

Maybe update the icon or make it an optional attribute? Thanks!

CorneeldH avatar Sep 19 '22 10:09 CorneeldH