bs4Dash icon indicating copy to clipboard operation
bs4Dash copied to clipboard

Published 20 hours ago • verified publisher icon RinteRface

bs4Dash::bs4Alert

Open yogat3ch opened this issue 2 years ago • 7 comments

Hi RinteRface devs, I noticed that bs4Alert is listed in the docs but seems to have gotten deleted from the package itself?

Searching the code base for bs4Alert only yields an entry in NEWS.md

yogat3ch avatar Dec 23 '21 21:12 yogat3ch

Thanks for the report. Let me check what is wrong.

DivadNojnarg avatar Jan 11 '22 10:01 DivadNojnarg

Thanks for checking into this @DavidNojnarg. I ended up re-making it. I don't know if that's helpful but thought I'd add it here

yogat3ch avatar Jan 26 '22 02:01 yogat3ch

Should I PR my version above with some docs? @DivadNojnarg

yogat3ch avatar Feb 02 '22 23:02 yogat3ch

Hi. Your link points me to a 404 error. I did not manage to find it in the currét version. Which bs4Dash version arz you using?

DivadNojnarg avatar Feb 03 '22 05:02 DivadNojnarg

That's bizarre. It's a public repo. This is what I see when I follow the link: image The latest dev version, albeit slightly modified. match_letters can be replaced with match.arg

yogat3ch avatar Feb 03 '22 21:02 yogat3ch

bs4Alert was removed from the last version and I don't plan to re-include it. Now there are createAlert and closeAlert which are just more flexible.

DivadNojnarg avatar Apr 20 '22 15:04 DivadNojnarg

@DivadNojnarg What if folks aren't looking for a pop-up and just want a static alert to show somewhere, as in my case? Why remove functionality that isn't effectively superseded when it doesn't add dependencies?

yogat3ch avatar Apr 23 '22 10:04 yogat3ch